fix: when loading a dashboard set the loaded flag after the fetch so state doesn't toggle back and forth #1975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenniferarnesen
requested review from
janhenrikoverland and
martinkrulltott
martinkrulltott
approved these changes
Sep 14, 2021
|
🚀 Deployed on https://pr-1975--dhis2-dashboard.netlify.app |
dhis2-bot
added a commit
that referenced
this pull request
Sep 15, 2021
## [31.19.11](v31.19.10...v31.19.11) (2021-09-15) ### Bug Fixes * **translations:** sync translations from transifex (master) ([#1968](#1968)) ([66070be](66070be)) * [email protected], [email protected] ([#1981](#1981)) ([30b25fb](30b25fb)) * in small screen make the "editing not possible" message the same whether in create or edit mode ([#1972](#1972)) ([1b9a193](1b9a193)) * remove other action buttons when in edit mode print preview ([#1974](#1974)) ([e9a54d1](e9a54d1)) * when loading a dashboard set the loaded flag after the fetch so state doesn't toggle back and forth ([#1975](#1975)) ([c9b4ff7](c9b4ff7))
|
🎉 This PR is included in version 31.19.11 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
loadedwas set to true before firing the fetch dashboards request. When that request failed due to the cache being hacked and deleted, thencatchsetloadedback to false. The result was thatloadedkept toggling between true and false.In addition, after discussion with Kai, it is not necessary to listen to
recordingStateto determine if loading is necessary. Note that removal of thatrecordingStatedoesn't impact any behavior.infinite.loading.fixed.mov